-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlist files, failsafe cleanup, multiple user actions, fixes #436
Open
resmh
wants to merge
44
commits into
scdl-org:master
Choose a base branch
from
resmh:playlist-files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… treated as errors
…downloaded tracks will not trigger errors. Implement Boolean return values.
…playlist-file-extension arguments
…ta information feedback
…sts (also known as stream)
…rupted tracks in a user-serviceable manner
…n not suitable for export
…kip folder if none can be found
…ieval of present files
…sence before calling download_track
resmh
force-pushed
the
playlist-files
branch
from
September 14, 2022 13:37
fd6bd09
to
c1fa44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for your downloader script!
To increase interoperability with media servers, I've added m3u playlist generation. Observing seldom, yet unresolvable hickup I've decided to add a failsafe mechanism that keeps playlists intact on recurrent runs. Likewise, if playlists are used, the cleanup function will only delete files that are not present in the respective folder's playlist. Furthermore I've enabled processing multiple requests on user profiles and set up a CD to deliver a docker image for testing under releases.
With kind regards,
Michael