optimize playlist track fetching + og file downloading #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently with playlists, each track is fetched 1 by 1 when iterating through. this can be improved by fetching the tracks using the
get_tracksfunction. the api endpoint it calls has a limit of 50 (i believe)one minor issue i ran into is that my current implementation seems to double the tracks? which is why i'm just making it a draft atm, but i've included a temporary workaround in the meantime
one more thing, when fetching the original file for a track, each track returns the
downloadableattribute. in thedownload_original_filefunction, we aren't checking for that for some reason, and instead calling the endpoint to fetch the url regardless of if they have downloads enabled or not.