Translateable behavior properties #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There shloud be propbably some more system solution then this hard overwrite.
|
Since it changes the return value of a Our proposal would be to add an additional index like WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opt-in the
Use Translatable Behaviorcheckbox, some additional code is generated to the model.The main point of the Translatable Behavior is bring the attributes from "language tables" to the main model via magic properties.
The generator already have the list of attributes, so it would be great if it could generate PHPDOC for the relevant properties to achieve auto-completion for IDE
I tried to make the changes, it works for me, hope I didn't break anything. It should be quite small but helpful change.