Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new plugin : Change Sentence To Mieum #140

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

sindpfla98
Copy link
Contributor

add new plugin = Change Sentence To Mieum

@sindpfla98 sindpfla98 closed this Jan 23, 2024
@sindpfla98 sindpfla98 reopened this Jan 23, 2024
@florianpircher
Copy link
Collaborator

Hi, thank you for adding the plugin!

In the description, you write that for Intel, instructions are on the GitHub page, but I cannot find them. What needs to be done to install the plugin on Intel Macs?

@sindpfla98
Copy link
Contributor Author

https://github.com/sindpfla98/ChangeSentenceToMieum?tab=readme-ov-file#for-intel-installation

I have written the file and how to install it here.

@florianpircher
Copy link
Collaborator

florianpircher commented Jan 23, 2024

In that case, you could also add two entries to the package index; one with an archs list of just arm and one with archs of just intel. M1/M2/M3/… users will just be shown the ARM entry, and Intel users will only see the Intel entry.

For this, you would need to add the Intel version of your plugin to the repository.

Option 1

Name the Intel version ChangeSentenceToMieum-Intel.glyphsPlugin (or similar). In the package index, add a duplicate entry, changing the path to match the Intel version and archs to ( intel ).

Option 2

Create a second branch in your ChangeSentenceToMieum repository and place the intel version there. In the package index, add a duplicate entry, adding branch = intel; and changing archs to ( intel ).


I think I prefer option 2, but option 1 works well, too. I can change the package index for you, if you would like, but since I have no access to your ChangeSentenceToMieum repository, you would need to do the first step of option 1 or 2.

Or, if you don’t want to maintain both the ARM and Intel versions in the repository, that is fine too, and I will merge this pull request immediately.

@sindpfla98
Copy link
Contributor Author

Thank you for telling me the new way. I'll try with the option 2 you recommended.

@florianpircher
Copy link
Collaborator

Thank you very much!

@florianpircher florianpircher merged commit 6db7a89 into schriftgestalt:glyphs3 Jan 23, 2024
1 check passed
@schriftgestalt
Copy link
Owner

it should be possible to build a universal version of the plugin. I found this that explains the process and some trouble shooting: dashingsoft/pyarmor#1408

@sindpfla98
Copy link
Contributor Author

Thank you, the way you told me seems to work very well, I'll update this again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants