Fixed an issue with the boolean negation operator

Fixed an issue where the boolean negation operator would modify the original boolean, instead of returning a new, negated one.
schwalbe-t · Jan 25, 2023 · 2f5220e · 2f5220e
1 parent c993665
commit 2f5220e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/currant.js b/currant.js
@@ -980,8 +980,7 @@ class CurrantNegateBooleanNode extends CurrantNode {
         let value = super.childValue(0);
         if(typeof value.get() !== "boolean")
             throw new Error(`failed to negate value - "${this.children[0].src}" is not a boolean`);
-        value.value[0] = !value.value[0];
-        return value;
+        return value.type.fromValue(!value.get());
     }
 
 }

diff --git a/currant/nodes/booleanLogic.js b/currant/nodes/booleanLogic.js
@@ -14,8 +14,7 @@ class CurrantNegateBooleanNode extends CurrantNode {
         let value = super.childValue(0);
         if(typeof value.get() !== "boolean")
             throw new Error(`failed to negate value - "${this.children[0].src}" is not a boolean`);
-        value.value[0] = !value.value[0];
-        return value;
+        return value.type.fromValue(!value.get());
     }
 
 }