-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Field for the Directory Intro Paragraph #749
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but mostly a note about preventing XSS. Data needs to be escaped at display time always unless we can guaranteed it is safe. We usually can't. A rule of thumb is "user input is lava" and we want to handle it very very carefully. We don't even mark ints or UUIDs as safe
when we display them even though we can assume quite strongly that they're always going to be safe. HTML that users input is never going be that, so when we pull from the DB it always needs to be cleaned/sanitized and then marked with a safe type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, still some changes, one of them being my fault for pointing you a little in the wrong direction :/
Optimize directory intro retrieval by reducing DB calls
621327b
to
afd4932
Compare
This PR adds a new feature that allows administrators to set a customizable introductory description for the user directory. This introductory text appears at the top of the directory page, providing context or guidelines to visitors and enhancing user engagement.
Key Changes:
DIRECTORY_INTRO
setting inOrganizationSetting
to store the introductory text for the user directory.DIRECTORY_INTRO
text.update_directory_intro_text
in the settings module to handle updates to the introductory text by admins.DIRECTORY_INTRO
text at the top of the directory page for all users.