-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disponibiliza o campo doi_prefix na API Journal #830
Merged
samuelveigarangel
merged 11 commits into
scieloorg:main
from
samuelveigarangel:issue-829
Oct 1, 2024
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3f16b24
Adiciona campo doi_prefix no modelo Journal
samuelveigarangel 6422895
Disponibiliza na API o campo doi_prefix
samuelveigarangel 03c0c8d
migracao
samuelveigarangel 0dd5668
Adiciona get_queryset para filtrar pelo doi_prefix que os periódicos …
samuelveigarangel 2f68ab8
Merge branch 'main' into issue-829
samuelveigarangel 076e1df
Altera queryset
samuelveigarangel 12008f1
Altera max_length de doi_prefix
samuelveigarangel 1603ba1
Merge branch 'issue-829' of https://github.com/samuelveigarangel/core…
samuelveigarangel a60cc39
Altera tamanho para 20
samuelveigarangel 89fb3c4
altera max_legth de doi_prefix para 20
samuelveigarangel f66b979
Merge branch 'main' into issue-829
samuelveigarangel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,4 +121,5 @@ class Meta: | |
"subject_descriptor", | ||
"subject", | ||
"text_language", | ||
"doi_prefix", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 5.0.3 on 2024-08-01 06:04 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("journal", "0026_editorialpolicy_opensciencecompliance"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="journal", | ||
name="doi_prefix", | ||
field=models.CharField(blank=True, max_length=100, null=True), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelveigarangel O meu comentário anterior diz que 50 para doi_prefix é muito, então 100, é demais. Tinha adicionado a documentação. Segue a imagem. Sugiro no máximo 20 e no mínimo 15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entendi seu comentário de forma errada e pensei que era para aumentar o tamanho. Pesquisei sobre o limite do tamanho do DOI e a única fonte que encontrei relacionada a isso foi: https://www.doi.org/resources/DOI_article_ELIS3.pdf. Na seção 'syntax', é informado que não há um limite definido para o tamanho do DOI, prefixo ou sufixo.