Cria Métodos de Classe no Modelo Article #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
article/models.py
Outdated
| def get_or_create(cls, doi, pid_v2, fundings, user): | ||
| def get( | ||
| cls, | ||
| doi, |
There was a problem hiding this comment.
@samuelveigarangel acho melhor remover o doi. Se é necessário recuperar artigos por DOI, melhor ter um método específico para isso.
article/models.py
Outdated
Comment on lines
248
to
249
| doi=None, | ||
| fundings=None, |
There was a problem hiding this comment.
@samuelveigarangel remover doi e fundings. O método create deveria somente aceitar pid_v3
article/models.py
Outdated
Comment on lines
269
to
270
| doi=None, | ||
| fundings=None, |
There was a problem hiding this comment.
@samuelveigarangel remover doi e fundings, deixar apenas pid_v3
article/sources/preprint.py
Outdated
| @@ -28,11 +28,9 @@ def harvest_preprints(URL, user): | |||
| identifier = get_doi(article_info["identifier"]) | |||
| doi = get_or_create_doi(doi=identifier, user=user) | |||
|
|
|||
| article = models.Article.get_or_create( | |||
| article = models.Article.create( | |||
There was a problem hiding this comment.
No caso, seria:
article = models.Article.objects.create(...)Os metodos de criação de Article exigem pid_v3
robertatakenaka
requested changes
Aug 14, 2024
… `models.Article.objects.create`
| @@ -28,7 +28,7 @@ def harvest_preprints(URL, user): | |||
| identifier = get_doi(article_info["identifier"]) | |||
| doi = get_or_create_doi(doi=identifier, user=user) | |||
|
|
|||
| article = models.Article.create( | |||
| article = models.Article.objects.create( | |||
There was a problem hiding this comment.
@samuelveigarangel Os artigos provenientes do preprint podem vir a entrar em alguma coleção SciELO. Então, isso tem que ser tratado para não duplicar...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Cria Métodos de Classe no Modelo Article
Onde a revisão poderia começar?
pelos commits
Como este poderia ser testado manualmente?
make up
Algum cenário de contexto que queira dar?
N/A
Screenshots
N/A
Quais são tickets relevantes?
#820
Referências
N/A