Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate feedback from Dan #83

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Mar 9, 2021

See #81.

@jarrodmillman jarrodmillman marked this pull request as draft March 9, 2021 01:04
Copy link
Member

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like reorganization of the process in terms of the "decision points" as I think it helps make clear that acceptance is not the end of the process, but rather the beginning. I also think the text in the decision points section clearly lays out what the responsibilities/roles of the various parties are at each stage.

I think the flow chart helps too. The boxes are clear as they correspond to the decision points, but it's not as clear what the words on the arrows represent: are they intended to represent the state of the document, or actions that are to be taken at that step? From context it seems like the latter, but the connection to the text is not as clearly defined as it is for the decision points.

@jarrodmillman jarrodmillman marked this pull request as ready for review March 11, 2021 01:12
@jarrodmillman jarrodmillman merged commit 9c56af3 into scientific-python:main Mar 11, 2021
@jarrodmillman jarrodmillman deleted the issue81 branch March 11, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants