Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop explicit awkward dependency #419

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Jul 5, 2023

Following #408 there was only one place left where awkward was used in the cabinetry code base, in cabinetry.tabulate. The use of awkward there was not crucial, so this is replaced by pure numpy here. This means that the explicit awkward dependency can be dropped from cabinetry. It still enters in cabinetry[contrib] via uproot.

* drop explicit dependency on awkward
* remove awkward HEAD tests from nightly CI tests

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7b9b6af) 100.00% compared to head (d5056f0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2072      2072           
  Branches       337       338    +1     
=========================================
  Hits          2072      2072           
Impacted Files Coverage Δ
src/cabinetry/tabulate.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held force-pushed the build/drop-awkward-dependency branch from 9179f29 to d5056f0 Compare July 5, 2023 21:23
@alexander-held alexander-held merged commit 7f46f03 into master Jul 5, 2023
@alexander-held alexander-held deleted the build/drop-awkward-dependency branch July 5, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant