Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support passing though dm, nicer typing #400

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Nov 28, 2023

The changes from #392, but in a branch that won't get force pushed by pre-commit weekly. Rebased after #398. Closes #399.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as draft November 28, 2023 18:08
@henryiii henryiii marked this pull request as ready for review November 28, 2023 21:10
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very neat idea/update. Thank you for that!

@eduardo-rodrigues eduardo-rodrigues self-assigned this Nov 29, 2023
@eduardo-rodrigues eduardo-rodrigues added the enhancement New feature or request label Nov 29, 2023
@eduardo-rodrigues eduardo-rodrigues merged commit 3dca6b9 into master Nov 29, 2023
11 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the henryiii/fix/types branch November 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants