Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove manual CGAL install #315

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Sep 16, 2024

  1. build: Remove manual CGAL install

    * Remove the manual download of CGAL from setup.py.
    * Remove '--with-cgaldir' autogen.sh flag as CGAL should be installed
      in a location by the package managers or user that it is findable.
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3086eea View commit details
    Browse the repository at this point in the history
  2. build: Add manual CGAL install for Linux cibuildwheel

    * The cibuildwheel Linux container is CentOS 7 based, but CGAL is
      not packaged for CentOS with yum --- only for apt-get, Homebrew,
      and conda-forge. For Linux cibuildwheel builds this then requires
      that the CGAL headers (CGLA is header only) need to be manually
      downloaded from GitHub and then copied into /usr/include/.
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    309e698 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bcf5d47 View commit details
    Browse the repository at this point in the history
  4. docs: Add libcgal-dev install to README

    * Add libcgal-dev to the required packages to install for Linux based
      development.
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7d4791c View commit details
    Browse the repository at this point in the history
  5. ci: Add cgal install to CI

    * Use package managers to install libcgal-dev (Linux) and cgal (macOS)
      in CI jobs.
    matthewfeickert committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e0c06d1 View commit details
    Browse the repository at this point in the history
  6. build: Remove '--enable-cgal' option as not compatible with '--enable…

    …-cgal-header-only'
    
    
    From `./configure --help`:
    
    ```
      --enable-cgal           enables link with the CGAL library default=no
      --enable-cgal-header-only   enable build with header-only install of CGAL, e.g. as for CGALv5; in that case do not use --enable-cgal default=no
    ```
    matthewfeickert authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    363f100 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Revert "build: Remove '--enable-cgal' option as not compatible with '…

    …--enable-cgal-header-only'"
    
    This reverts commit 363f100.
    matthewfeickert committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    90d6137 View commit details
    Browse the repository at this point in the history