Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minuit.interactive outside of Jupyter notebooks #1056

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
0aa85f2
Added PyQt6 widget and added ax kwarg to the visualize methods
adryyan Oct 28, 2024
59c3bf8
Added PyQt6 optional dependency
adryyan Oct 29, 2024
51bbf1f
Added tests
adryyan Oct 29, 2024
1367a88
Bug fixes
Nov 1, 2024
7f22e49
Added get_ipython import for tests
Nov 1, 2024
dae61d0
Fixed tests
Nov 1, 2024
aa29da3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 1, 2024
b90fdb1
Only return QMainWindow
Nov 3, 2024
02fc792
Fixed centering in ComboBox
Nov 3, 2024
cba417d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2024
9485f85
Added context manager for signal blocking
adryyan Dec 6, 2024
e20f357
Changed partial to lambda
adryyan Dec 6, 2024
2342b7d
Removed qt_exec arg and changed QMainWindow to QWidget
Dec 6, 2024
92f7c83
Removed tabs and added more decimals to SpinBox
Dec 6, 2024
cf0ee81
Moved _make_finite and _guess_initial_step to util
adryyan Dec 11, 2024
7a6f7af
Changed starting of event loop
adryyan Dec 11, 2024
1ba8065
Removed unnecessary lines
adryyan Dec 11, 2024
0901a46
Clean up
adryyan Dec 11, 2024
f7c4fd5
Moved mock ipython fixture to conftest.py
adryyan Dec 11, 2024
2813c51
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 11, 2024
a50b5e5
Removed repeated lines
adryyan Dec 11, 2024
b1fbd3f
Back to pyplot
adryyan Dec 12, 2024
c54c2d9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 12, 2024
122daff
Merge branch 'develop' into qtwidget
HDembinski Dec 12, 2024
22dcf94
Removed _widget prefix
adryyan Dec 12, 2024
70e930a
Added run_event_loop argument
adryyan Dec 12, 2024
9d7cc47
Changed layout
adryyan Dec 12, 2024
811b27b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 12, 2024
30a1184
Added is_jupyter
adryyan Dec 13, 2024
6e56da0
Moved run_event_loop to make_widget
adryyan Dec 13, 2024
5c866ae
Use is_jupyter from util and remove run_event_loop
adryyan Dec 13, 2024
0ec2969
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 13, 2024
f034929
Added fmin display to qtwidget
adryyan Dec 13, 2024
7f873ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 13, 2024
24ccc77
Removed success message
adryyan Dec 13, 2024
1ce9ea3
Merge branch 'develop' into qtwidget
HDembinski Dec 16, 2024
2fda767
Fixed importskips
Dec 16, 2024
6c5f02b
Ruff ignore conftest.py
Dec 16, 2024
63e0082
block_signals -> _block_signals
Dec 16, 2024
2d872ab
attempt to fix ci
HDembinski Dec 17, 2024
3ffd0c8
attempt to fix
HDembinski Dec 17, 2024
7ec04b2
attempt to fix ci
HDembinski Dec 17, 2024
8d50cbe
attempt to fix ci
HDembinski Dec 17, 2024
17abd16
attempt to fix ci
HDembinski Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unnecessary lines
  • Loading branch information
adryyan committed Dec 11, 2024
commit 1ba806509c8ee09633a78bfa31fb4133c5a8dfb1
9 changes: 1 addition & 8 deletions tests/test_without_pyqt6.py
Original file line number Diff line number Diff line change
@@ -10,14 +10,7 @@ def test_interactive(qtbot):
import iminuit

cost = LeastSquares([1.1, 2.2], [3.3, 4.4], 1, lambda x, a: a * x)
mw = iminuit.Minuit(cost, 1).interactive(qt_exec=False)
qtbot.addWidget(mw)
mw.close()
mw.deleteLater()

with hide_modules("PyQt6", reload="iminuit.qtwidget"):
with pytest.raises(ModuleNotFoundError, match="Please install"):
mw = iminuit.Minuit(cost, 1).interactive(qt_exec=False)
qtbot.addWidget(mw)
mw.close()
mw.deleteLater()
iminuit.Minuit(cost, 1).interactive()