-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Promote modifications to public API #2339
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
==========================================
+ Coverage 97.59% 98.28% +0.68%
==========================================
Files 69 69
Lines 4538 4538
Branches 803 803
==========================================
+ Hits 4429 4460 +31
+ Misses 65 45 -20
+ Partials 44 33 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
45c08c8
to
f7ba736
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kratsg. I just have a docs styling comment, but other than that LGTM.
(Though maybe we also wait to see if @alexander-held has any comments before merge, given that he opened up Issue #1652) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else from me, thanks for addressing this!
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @kratsg!
Pull Request Description
Resolves #1652.
Docs: https://pyhf--2339.org.readthedocs.build/en/2339/_generated/pyhf.pdf.Model.html#pyhf.pdf.Model
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: