fix: Remove os-dependent pieces of schema validation #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratsg
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 69 69
Lines 4538 4539 +1
Branches 803 803
=======================================
+ Hits 4460 4461 +1
Misses 45 45
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
matthewfeickert
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks @kratsg. I just did some typo fixes and also linked to python/cpython#65238.
matthewfeickert
added
docs
kratsg
changed the title
matthewfeickert
changed the title
|
@kratsg I see that you want to keep this in draft mode for the time being. I am okay to merge this whenever you're ready assuming no additional large changes. |
matthewfeickert
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks for checking this against both Windows 10 and Windows 11, @kratsg. 👍
4 tasks
matthewfeickert
removed
bug
matthewfeickert
added a commit
that referenced
this pull request
Oct 25, 2023
* Backport PR #2357 * Use pathlib to build the stem for the schema to use (version + type of schema). - c.f. python/cpython#65238 Co-authored-by: Giordon Stark <kratsg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves #2353. To allow
pyhfto work a little bit better, at least on schemas on Windows, need to rely either onpathlibmore fully oros.sepin order to build the paths correctly.add an additional example that is os-independentChecklist Before Requesting Reviewer
Before Merging
For the PR Assignees: