-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use Apple silicon for the default macOS runners #2471
ci: Use Apple silicon for the default macOS runners #2471
Conversation
* Use the 'macos-latest' runs-on option which now defaults to 'macos-14' which are Apple silicon runners. - c.f. https://github.com/actions/runner-images/blob/e63a194563cb0bb3bc1493144fe0ef6804249b43/images/macos/macos-14-arm64-Readme.md * Keep a 'macos-13' runners to continue to test Intel based macOS for the latest Python version. - c.f. https://github.com/actions/runner-images/blob/e63a194563cb0bb3bc1493144fe0ef6804249b43/images/macos/macos-13-Readme.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 69 69
Lines 4543 4543
Branches 804 804
=======================================
Hits 4462 4462
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think I'd use |
Though from the time taken it is obviously AS, and probably it will never go back once bumped on a repo. |
@henryiii is the rollout repository specific or random assignment? If it is repository based then (https://github.com/scikit-hep/pyhf/actions/runs/8843240294/job/24283156332?pr=2471#step:1:8)
|
I'm pretty sure it's repo specific. Once you bump up, I think it doesn't bump back down. |
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
Description
Updates PR #2468
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: