Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more RNTuple files #151

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

ariostas
Copy link
Collaborator

I added three more RNTuple files that have been useful to test and debug uproot. These files were created and used by @Moelf for UnROOT testing, and can be found here.

@Moelf
Copy link
Collaborator

Moelf commented Apr 17, 2024

it may be a good idea to copy the source code to https://github.com/scikit-hep/scikit-hep-testdata/tree/main/dev/make-root and generate yourself to make sure!

@ariostas
Copy link
Collaborator Author

Thanks @Moelf! For Run2012BC_DoubleMuParked_Muons_rntuple_1000evts.root I couldn't find the original Run2012BC_DoubleMuParked_Muons.root file in the UnROOT repo. For test_ntuple_extension_columns.root, I don't have access to a raw ATLAS file. And I'm not sure how DAOD_TRUTH3_RC2.root was generated.

@ariostas
Copy link
Collaborator Author

For Run2012BC_DoubleMuParked_Muons_rntuple_1000evts.root I couldn't find the original Run2012BC_DoubleMuParked_Muons.root file in the UnROOT repo.

Sorry, I just realized that that's a public file.

@Moelf
Copy link
Collaborator

Moelf commented Apr 17, 2024

oh you're right... yeah those files are a bit cryptic, indeed I had to produce them with ATLAS stuff. This is as good as it can be for the moment I think

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (9ed1610) to head (375691a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   69.78%   70.00%   +0.21%     
==========================================
  Files           3        3              
  Lines         139      140       +1     
==========================================
+ Hits           97       98       +1     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariostas ariostas marked this pull request as draft April 17, 2024 21:16
@ariostas
Copy link
Collaborator Author

I added partial instructions for how to generate these files, like in the UnROOT repo.

I'll look into writing some script to generate similar test files without having to use any ATLAS tools.

@ariostas ariostas marked this pull request as ready for review April 18, 2024 19:33
@ariostas
Copy link
Collaborator Author

@jpivarski seems like I can't request a reviewer since I'm not a member of this repo (or scikit-hep), but this is ready for review now.

@jpivarski jpivarski merged commit 5cfc276 into scikit-hep:main Apr 18, 2024
6 checks passed
@jpivarski
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants