Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates on new points #14

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

wreise
Copy link

@wreise wreise commented Oct 17, 2023

Implements #9 : circular and toroidal coordinates on new points.

To-do:

  • Treat the case when X_query is a distance matrix.
  • Projective coordinates

@LuisScoccola
Copy link
Collaborator

Thank you for starting this, @wreise! And sorry for the late reply. This looks quite promising. I ask that you also please add tests (maybe this can be another item in your to-do). As a heads-up: there will be a few minor changes pushed to main soon, which will require rebasing (see #13).

I see that this is a draft for now, do you want me to check anything specific or wait until further progress is done?

Thanks again for your contribution!

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #14 (dfdc540) into master (9ced70d) will decrease coverage by 0.23%.
The diff coverage is 63.63%.

❗ Current head dfdc540 differs from pull request most recent head 470e450. Consider uploading reports for the commit 470e450 to get more accurate results

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   72.64%   72.42%   -0.23%     
==========================================
  Files          10       10              
  Lines        1053     1059       +6     
  Branches      189      191       +2     
==========================================
+ Hits          765      767       +2     
- Misses        269      271       +2     
- Partials       19       21       +2     
Files Coverage Δ
dreimac/circularcoords.py 100.00% <ø> (ø)
dreimac/emcoords.py 84.72% <75.00%> (-2.05%) ⬇️
dreimac/toroidalcoords.py 96.02% <33.33%> (-1.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wreise
Copy link
Author

wreise commented Oct 25, 2023

I ask that you also please add tests

I forgot to commit the tests. Could you perhaps just trigger the automated tests on the newest commit?

As a heads-up: there will be a few minor changes pushed to main soon, which will require rebasing

Noted!

I'm afraid that the projective coordinates will have to wait a bit: I will probably un-draft the PR when I have a version of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants