Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to pyproject.toml spec #18

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

catanzaromj
Copy link
Contributor

This PR converts DREiMac to using the pyproject.toml style of specification, as wheel as using setuptools for building wheels.

@LuisScoccola Please double check the email addresses, license, keywords and urls specificed in the pyproject.toml file.

@catanzaromj catanzaromj self-assigned this Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.57%. Comparing base (ca37386) to head (b5e6a16).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files          10       10           
  Lines        1050     1050           
  Branches      189      189           
=======================================
  Hits          762      762           
  Misses        269      269           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@catanzaromj catanzaromj marked this pull request as ready for review September 7, 2024 16:07
@LuisScoccola
Copy link
Collaborator

Thanks a lot @catanzaromj, this is great! I confirm email addresses, license, keywords and urls look good.

@ctralie, do you want to take a look before I merge to master?

@LuisScoccola
Copy link
Collaborator

One comment is that CHANGELOG.md is not really being used. Should we keep it in pyproject.toml?

@catanzaromj
Copy link
Contributor Author

@LuisScoccola Makes sense. I removed it from pyproject.toml.

@ctralie
Copy link
Member

ctralie commented Sep 8, 2024

Thanks a lot @catanzaromj, this is great! I confirm email addresses, license, keywords and urls look good.

@ctralie, do you want to take a look before I merge to master?

All good by me, thank you so much for helping to maintain this!

@LuisScoccola LuisScoccola merged commit 17cd2b1 into scikit-tda:master Sep 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants