added flag for not requiring user action #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, this looks good to me. |
bryankennedy
approved these changes
Jan 12, 2021
|
I know this is from a lifetime ago, but I'm just clearing out my review requests. Sorry I never saw this one before. |
|
We're picking this work back up in https://smm.atlassian.net/browse/EXTCH-23 and https://smm.atlassian.net/browse/EXTCH-97 I think that this should be enabled in a distinct release from some of the general Stele upgrade work. I'll merge this in as a separate release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flag so that user interaction is not required to play audio files. (Specifically, this allows us to trigger audio files to project visualizations in the Time room of the Infestation project.) Playing audio and video without user interaction is disallowed by default in Chrome.