Merge pull request #410 from yanntech/fix/hipchat-urlencode

add urlencode in roomId
scobal · Sep 18, 2016 · 5e1ae22 · 5e1ae22
2 parents e40cdd0 + 9c03757
commit 5e1ae22
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...n-core/src/main/java/com/seyren/core/service/notification/HipChatNotificationService.java b/...n-core/src/main/java/com/seyren/core/service/notification/HipChatNotificationService.java
@@ -15,6 +15,7 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.net.URLEncoder;
 
 import javax.inject.Inject;
 import javax.inject.Named;
@@ -86,10 +87,11 @@ private void sendMessage(String message, MessageColor color, String[] roomIds, S
         for (String roomId : roomIds) {
             LOGGER.info("Posting: {} to {}: {} {}", from, roomId, message, color);
             HttpClient client = HttpClientBuilder.create().useSystemProperties().build();
-            String url = baseUrl + "/v2/room/" + roomId + "/notification?auth_token=" + authToken;
-            HttpPost post = new HttpPost(url);
+            HttpPost post = new HttpPost();
 
             try {
+                String url = baseUrl + "/v2/room/" + URLEncoder.encode(roomId, "UTF-8").replaceAll("\\+", "%20") + "/notification?auth_token=" + authToken;
+                post = new HttpPost(url);
                 List<BasicNameValuePair> parameters = new ArrayList<BasicNameValuePair>();
                 parameters.add(new BasicNameValuePair("message", message));
                 parameters.add(new BasicNameValuePair("color", color.name().toLowerCase()));