fix: placeholders not replaced in resource params

Signed-off-by: Chris Stephenson <chris.stephenson@humanitec.com>
score-spec · Aug 23, 2023 · 069dcdf · 069dcdf
1 parent 56cd6b0
commit 069dcdf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/internal/humanitec/convert.go b/internal/humanitec/convert.go
@@ -233,7 +233,7 @@ func ConvertSpec(name, envID string, spec *score.WorkloadSpec, ext *extensions.H
  "type": res.Type,
  }
  if len(res.Params) > 0 {
- extRes["params"] = res.Params
+ extRes["params"] = ctx.SubstituteAll(res.Params)
  }
  externals[resName] = extRes
  } else if scope == "shared" {
@@ -242,7 +242,7 @@ func ConvertSpec(name, envID string, spec *score.WorkloadSpec, ext *extensions.H
  "type": res.Type,
  }
  if len(res.Params) > 0 {
- sharedRes["params"] = res.Params
+ sharedRes["params"] = ctx.SubstituteAll(res.Params)
  }
  shared = append(shared, humanitec.UpdateAction{
  Operation: "add",

diff --git a/internal/humanitec/convert_test.go b/internal/humanitec/convert_test.go
@@ -316,6 +316,12 @@ func TestScoreConvert(t *testing.T) {
  },
  Type: "some-type",
  },
+ "route": {
+ Type: "route",
+ Params: map[string]interface{}{
+ "host": "${resources.dns.host}",
+ },
+ },
  },
  },
  Extensions: &extensions.HumanitecExtensionsSpec{
@@ -410,6 +416,12 @@ func TestScoreConvert(t *testing.T) {
  },
  },
  },
+ "route": map[string]interface{}{
+ "type": "route",
+ "params": map[string]interface{}{
+ "host": "${shared.dns.host}",
+ },
+ },
  },
  },
  },