Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

feat: use resource id aliases in deltas for non-default classes #68

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

chrishumanitec
Copy link
Contributor

If the score.humanitec.io/resId annotation is set on a resoutce type AND the class is specified AND it is not default then generate a new resource dependency in the delta with a resource name that contains the suffix -class-{className}

Description

Changes in:

  • The template code that builds the substitutions for resource placeholders
  • The converter which generates the delta from the sepc.

What does this PR do?

The PR addresses this issue: [/issues/67]

Note: in the circumstance where a shared resource is already used with a class - a new resource dependency will be added to teh delta. This is a material change to teh deployment set but is not an effective change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: Chris Stephenson <chris.stephenson@humanitec.com>
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The solution matches what was described in #67

Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@johanneswuerbach johanneswuerbach merged commit 6cb503d into main Feb 1, 2024
3 checks passed
@johanneswuerbach johanneswuerbach deleted the resource-id-alias branch February 1, 2024 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants