This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
fix: add immage flag for . image convention #69
Merged
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-i|--image
flag to allow for specifying the image to override when theimage
property in a score file has a value.
Description
.containers.{containerId}.image
where the value is.
What does this PR do?
It is a convention when working with score that setting the image to
.
means: "the image in the current context". Usually, this means the image that is associated with the score file. The CI pipeline will know the generated image to be inserted.Today, there are a number of workarounds involving
--property
overrides (which require knowledge of the container IDs) or evensed
scripts such as:This change will make updated in the current image much simpler:
Types of changes
Checklist: