Show default message for UnauthorizedException (#123)

* Add regression test for default unauthorized message * Pass default message correctly
scrnhq · Sep 9, 2019 · 34386ac · 34386ac
1 parent 2986922
commit 34386ac
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 10 deletions.
diff --git a/src/Exceptions/UnauthorizedException.php b/src/Exceptions/UnauthorizedException.php
@@ -7,8 +7,10 @@
 
 class UnauthorizedException extends UserError
 {
- public function __construct($message = 'This action is unauthorized.', $code = 0, Throwable $previous = null)
+ public function __construct($message = null, $code = null, Throwable $previous = null)
  {
- parent::__construct($message, $code, $previous);
+ parent::__construct($message ?: 'This action is unauthorized.', 0, $previous);
+
+ $this->code = $code ?: 0;
  }
 }
diff --git a/tests/Feature/CustomMutationTest.php b/tests/Feature/CustomMutationTest.php
@@ -43,17 +43,32 @@ public function it_validates_a_custom_mutation()
  }
 
  /** @test */
- public function it_checks_authorization_for_a_custom_mutation()
+ public function it_checks_authorization()
  {
- $this->withExceptionHandling();
- $this->graphql('mutation($input: InviteUserInput!) { inviteUser(input: $input) }', [
- 'input' => [
- 'email' => 'john@example.com',
- ],
- ])->assertJsonFragment(['message' => 'You need to be logged in to do this!']);
+ $this->withExceptionHandling()
+ ->graphql('mutation($input: InviteUserInput!) { inviteUser(input: $input) }', [
+ 'input' => ['email' => 'john@example.com'],
+ ])->assertJsonFragment(['message' => 'This action is unauthorized.']);
 
  $this->assertDatabaseMissing('users', [
  'email' => 'invalid-email',
  ]);
  }
+
+ /** @test */
+ public function it_checks_authorization_and_shows_custom_message()
+ {
+ $_SERVER['graphql.inviteUser.authorize'] = 'You need to be logged in to do this!';
+
+ $this->withExceptionHandling()
+ ->graphql('mutation($input: InviteUserInput!) { inviteUser(input: $input) }', [
+ 'input' => ['email' => 'fail@example.com'],
+ ])->assertJsonFragment(['message' => 'You need to be logged in to do this!']);
+
+ $this->assertDatabaseMissing('users', [
+ 'email' => 'invalid-email',
+ ]);
+
+ unset($_SERVER['graphql.inviteUser.authorize']);
+ }
 }
diff --git a/tests/Fixtures/Mutations/InviteUserMutation.php b/tests/Fixtures/Mutations/InviteUserMutation.php
@@ -61,7 +61,7 @@ public function attributes()
  public function authorize()
  {
  if (! auth()->user()) {
- return $this->deny('You need to be logged in to do this!');
+ return $this->deny($_SERVER['graphql.inviteUser.authorize'] ?? null);
  }
 
  return true;