clippy #339
Annotations
7 errors and 12 warnings
an array of `Range` that is only one element:
halo2_gadgets/src/utilities.rs#L408
error: an array of `Range` that is only one element
--> halo2_gadgets/src/utilities.rs:408:47
|
408 | decompose(pallas::Base::random(rng), &[0..255]);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `-D clippy::single-range-in-vec-init` implied by `-D warnings`
help: if you wanted a `Vec` that contains the entire range, try
|
408 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 255, try
|
408 | decompose(pallas::Base::random(rng), &[0; 255]);
| ~~~~~~
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L282
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:282:32
|
282 | .chain(zs_complete.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_complete`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L281
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:281:32
|
281 | .chain(zs_incomplete_lo.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_lo`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L280
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:280:32
|
280 | .chain(zs_incomplete_hi.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_hi`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L282
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:282:32
|
282 | .chain(zs_complete.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_complete`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L281
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:281:32
|
281 | .chain(zs_incomplete_lo.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_lo`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L280
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:280:32
|
280 | .chain(zs_incomplete_hi.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_hi`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
an array of `Range` that is only one element:
halo2_gadgets/src/utilities.rs#L408
warning: an array of `Range` that is only one element
--> halo2_gadgets/src/utilities.rs:408:47
|
408 | decompose(pallas::Base::random(rng), &[0..255]);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
help: if you wanted a `Vec` that contains the entire range, try
|
408 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 255, try
|
408 | decompose(pallas::Base::random(rng), &[0; 255]);
| ~~~~~~
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L282
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:282:32
|
282 | .chain(zs_complete.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_complete`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L281
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:281:32
|
281 | .chain(zs_incomplete_lo.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_lo`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L280
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:280:32
|
280 | .chain(zs_incomplete_hi.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_hi`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L282
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:282:32
|
282 | .chain(zs_complete.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_complete`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L281
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:281:32
|
281 | .chain(zs_incomplete_lo.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_lo`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/ecc/chip/mul.rs#L280
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/ecc/chip/mul.rs:280:32
|
280 | .chain(zs_incomplete_hi.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `zs_incomplete_hi`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|