Skip to content

add todo in mv_lookup's prover

Sign in for the full log view
GitHub Actions / Clippy (1.56.1) failed Nov 14, 2023 in 0s

Clippy (1.56.1)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.63.0 (4b91a6ea7 2022-08-08)
  • cargo 1.63.0 (fd9c4297c 2022-07-01)
  • clippy 0.1.63 (4b91a6e 2022-08-08)

Annotations

Check failure on line 483 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

redundant closure

error: redundant closure
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:483:22
    |
483 |                 .map(|i| Fr::from(i))
    |                      ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Fr::from`
    |
    = note: `-D clippy::redundant-closure` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 481 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `table`

error: unused variable: `table`
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:481:17
    |
481 |             let table: BTreeMap<Fr, usize> = (0..n)
    |                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_table`

Check failure on line 469 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `table`

error: unused variable: `table`
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:469:17
    |
469 |             let table: BTreeMap<Fr, usize> = (0..n)
    |                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_table`
    |
    = note: `-D unused-variables` implied by `-D warnings`

Check failure on line 454 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unresolved import `env_logger`

error[E0432]: unresolved import `env_logger`
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:454:9
    |
454 |     use env_logger::init;
    |         ^^^^^^^^^^ use of undeclared crate or module `env_logger`