Implement TLOAD and TSTORE #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z2trillion
force-pushed
the
feat/tload_tstore
branch
from
eb8bf52 to
8a80e02
Compare
z2trillion
force-pushed
the
feat/tload_tstore
branch
4 times, most recently
from
5ee85ee to
8b95ad3
Compare
added 2 commits
April 25, 2024 14:26
lispc
reviewed
Apr 26, 2024
| // removed rwc_inner_chunk here... does that matter? | ||
| self.transient_storage.push(Operation::new(rwc, rw, op)); | ||
| OperationRef::from((Target::TransientStorage, self.transient_storage.len() - 1)) | ||
| } |
There was a problem hiding this comment.
better to keep rwc check. (the rwc check is used for early terminate, to avoid rws cost too much memory to make l2geth down. while for tload/tstore, the 100 gas cost is non trivial, you cannot create too many tload/tstores. Anyway, keeping rwc_check makes code more consistent.)
lispc
reviewed
Apr 26, 2024
| @@ -581,6 +599,8 @@ impl Rw { | |||
| Self::Memory { .. } => RwTableTag::Memory, | |||
| Self::Stack { .. } => RwTableTag::Stack, | |||
| Self::AccountStorage { .. } => RwTableTag::AccountStorage, | |||
| // TODO: pick one! | |||
| Self::AccountTransientStorage { .. } => RwTableTag::TransientStorage, | |||
lispc
reviewed
Apr 26, 2024
| // state.stack_read(&mut exec_step, value_stack_position, value)?; | ||
|
|
||
| let (_, value_prev) = state.sdb.get_transient_storage(&contract_addr, &key); | ||
| let value_prev = *value_prev; |
There was a problem hiding this comment.
why we need value_prev? (SSTORE needs value_prev since it is related to gas cost)
|
i think you forget to modify |
|
I have added the changes by @lispc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[PR description]
Issue Link
[link issue here]
Type of change
Contents
Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]
How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
Design choices
RECOMMENDED to: