Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-5: prover Refactor #1446

Merged
merged 18 commits into from
Nov 8, 2024
Merged

Upgrade-5: prover Refactor #1446

merged 18 commits into from
Nov 8, 2024

Conversation

roynalnaruto
Copy link

Description

Refactor the prover crate for:

  • Better code organisation
  • Inline documentation
  • Better structure and lesser duplication

Notice

Requires re-running e2e tests and debugging potentially regression issues in the prover crate's behaviour:

  1. scroll-prover: https://github.com/scroll-tech/scroll-prover
  2. scroll/prover: https://github.com/scroll-tech/scroll/tree/develop/prover

@roynalnaruto roynalnaruto changed the title Feat/upgrade5 prover Upgrade-5: prover Refactor Nov 6, 2024
@roynalnaruto
Copy link
Author

@amoylan2 please refer the updates in this PR to also make corresponding changes in scroll/prover. @noel2004 will also be able to help.

@roynalnaruto roynalnaruto requested a review from amoylan2 November 6, 2024 14:41
@lispc
Copy link

lispc commented Nov 7, 2024

@amoylan2 please refer the updates in this PR to also make corresponding changes in scroll/prover. @noel2004 will also be able to help.

Btw this time we upgraded rust version and many low level libraries. So for now better only testing this branch, later we will pick some needed changes to v0.13 for dual version support..

/// accumulator.
///
/// Every SNARK layer on top of the [`innermost layer`][LayerId::Inner] has an accumulator.
pub fn accumulator(&self) -> bool {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to has_accumulator?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a planned change. I have not yet removed the has_accumulator argument from function calls.

Copy link

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactor of Err and Proof.

can be merged after e2e testing in scroll-prover

@lispc
Copy link

lispc commented Nov 7, 2024

i will help with e2e testing.

@lispc
Copy link

lispc commented Nov 7, 2024

need to change


/// Defines a proving task for bundle proof generation.
#[derive(Debug, Clone, Deserialize, Serialize)]
pub struct BundleProvingTask {
    /// The [`BatchProofs`][BatchProof] for the contiguous list of batches to be bundled together.
    pub batch_proofs: Vec<BatchProof>,
}

to BatchProofV2?

@lispc lispc merged commit 7fd6b6d into develop Nov 8, 2024
17 checks passed
@lispc lispc deleted the feat/upgrade5-prover branch November 8, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants