Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICONS: add more gob games to TOC.md #335

Merged
merged 4 commits into from
Aug 15, 2024
Merged

ICONS: add more gob games to TOC.md #335

merged 4 commits into from
Aug 15, 2024

Conversation

BJNFNE
Copy link
Contributor

@BJNFNE BJNFNE commented Aug 14, 2024

No description provided.

TOC.md Outdated
@@ -432,7 +432,7 @@
| ✅ | gob | adi5 | ADI 5 | GandalfTheWhite80 |
| ✅ | gob | adibou1 | ADIBOU 1 | sdelamarre, GandalfTheWhite80 |
| ✅ | gob | adibou2 | ADIBOU 2 | sdelamarre, GandalfTheWhite80 |
| ✅ | gob | adibou3 | ADIBOU 3 | sdelamarre, GandalfTheWhite80, BJNFNE |
| ✅ | gob | adibou3 | Adibou 3 | sdelamarre, GandalfTheWhite80, BJNFNE |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you change Adibou 1/2 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADIBOU 1 and ADIBOU 2 uses uppercase for some versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Adibou 3, Coktel Vision began to write Adibou in lowercase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADIBOU 1 and ADIBOU 2 uses uppercase for some versions

All right, but like this it looks inconsistent. Also rename the other two or leave it as is. In any case this is merely a TOC and these minor changes aren't really needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we may leave it as it is an revert /exclude the ADIBOU 3 related commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok revert it then I'll squash and merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert commit is pushed

@tag2015
Copy link
Contributor

tag2015 commented Aug 15, 2024

Thanks! Squashing

@tag2015 tag2015 merged commit 6f35ddf into scummvm:master Aug 15, 2024
@BJNFNE BJNFNE deleted the toc-gob branch August 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants