INTEGRITY: Rewrite project in python #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user_fileset_funtions.py
sev-
requested changes
Jun 14, 2024
| user = f'cli:{getpass.getuser()}' | ||
| create_log(escape_string(category_text), user, escape_string(log_text), conn) | ||
|
|
||
| def compare_filesets(id1, id2, conn): |
There was a problem hiding this comment.
I think this will not scale well since you're basically doing quadratic computation.
I propose the following approach:
*Pick a file from the incoming fileset
- Select from the fileset set of fileset ids that have these files with checksum matching. should be a single SELECT
- If the list is too big, like, over 100 entries (low chance), add one more file
- Iterate over the resulting files, or even ask SQL to do it with UNION ALL
Eventually, we will have like 15k filesets, so quadratic computations are not feasible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.