You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The methods in the metadata module would benefit from revision, especially regarding the parameters. In some cases, the parameter inference and default settings could be improved or, at least, better documented.
In CellLine.annotate_bulk_rna, the reference_id is implicitly set to DepMap_ID, and a warning is raised to inform the user of the steps to take if that column is not present. This process could be improved by explicitly checking whether DepMap_ID is available in adata.obs and, if it is not, raising an error (or a warning). (see code here)
In CellLine.correlate, we check if the gene names are different and issue a warning if they are. We should discuss whether it makes more sense to let the method to fail if the names do not match. If not, the warning should at least clarify the implications of this discrepancy. (see code here)
The text was updated successfully, but these errors were encountered:
Description of feature
The methods in the metadata module would benefit from revision, especially regarding the parameters. In some cases, the parameter inference and default settings could be improved or, at least, better documented.
Two specific things discussed in scverse/pertpy-tutorials#48:
CellLine.annotate_bulk_rna
, thereference_id
is implicitly set toDepMap_ID
, and a warning is raised to inform the user of the steps to take if that column is not present. This process could be improved by explicitly checking whetherDepMap_ID
is available inadata.obs
and, if it is not, raising an error (or a warning). (see code here)CellLine.correlate
, we check if the gene names are different and issue a warning if they are. We should discuss whether it makes more sense to let the method to fail if the names do not match. If not, the warning should at least clarify the implications of this discrepancy. (see code here)The text was updated successfully, but these errors were encountered: