Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(WorkArea.svelte): Add global search to the Workspace #487

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

k0machi
Copy link
Collaborator

@k0machi k0machi commented Oct 21, 2024

This commit adds a global search bar to the Workspace page. This bar
allows user to search Argus for any test, group or release names, as
well as specific run ids. The following hapens for each:

  • Test: a Test selector is added and shown to the user.
  • Group: all Tests from a Group are added to the selector.
  • Release: a Grid View is shown to the user to pick a single group or
    test
  • Test Run: a Test selector is added with a selected run automatically
    opened

@k0machi k0machi self-assigned this Oct 21, 2024
@k0machi k0machi changed the title global test searchbar feature(WorkArea.svelte): Add global search to the Workspace Oct 21, 2024
@k0machi
Copy link
Collaborator Author

k0machi commented Oct 21, 2024

Needs #459 to be merged first.

@k0machi
Copy link
Collaborator Author

k0machi commented Oct 21, 2024

Demo:

OBS_2024-10-21_14-02-37.mkv.mp4

@soyacz
Copy link
Collaborator

soyacz commented Oct 21, 2024

would be nice to show hint how it can be searched. E.g. in demo you used release:5.4 - let's have a small legend on how to search (e.g maybe when clicking on search bar, before typing anything could show help?)

@k0machi k0machi force-pushed the global-test-searchbar branch 2 times, most recently from 5f0abcc to e720066 Compare October 21, 2024 14:01
@k0machi
Copy link
Collaborator Author

k0machi commented Oct 21, 2024

would be nice to show hint how it can be searched. E.g. in demo you used release:5.4 - let's have a small legend on how to search (e.g maybe when clicking on search bar, before typing anything could show help?)

image

Added.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0machi k0machi force-pushed the global-test-searchbar branch 2 times, most recently from 43dce21 to d3de816 Compare October 31, 2024 11:22
This commit adds a global search bar to the Workspace page. This bar
allows user to search Argus for any test, group or release names, as
well as specific run ids. The following hapens for each:

* Test: a Test selector is added and shown to the user.
* Group: all Tests from a Group are added to the selector.
* Release: a Grid View is shown to the user to pick a single group or
  test
* Test Run: a Test selector is added with a selected run automatically
  opened
@k0machi k0machi merged commit 8282336 into scylladb:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants