-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(WorkArea.svelte): Add global search to the Workspace #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0machi
changed the title
global test searchbar
feature(WorkArea.svelte): Add global search to the Workspace
Oct 21, 2024
Needs #459 to be merged first. |
Demo: OBS_2024-10-21_14-02-37.mkv.mp4 |
would be nice to show hint how it can be searched. E.g. in demo you used |
k0machi
force-pushed
the
global-test-searchbar
branch
2 times, most recently
from
October 21, 2024 14:01
5f0abcc
to
e720066
Compare
k0machi
force-pushed
the
global-test-searchbar
branch
from
October 28, 2024 14:18
e720066
to
5d9168a
Compare
roydahan
approved these changes
Oct 28, 2024
fruch
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
k0machi
force-pushed
the
global-test-searchbar
branch
2 times, most recently
from
October 31, 2024 11:22
43dce21
to
d3de816
Compare
This commit adds a global search bar to the Workspace page. This bar allows user to search Argus for any test, group or release names, as well as specific run ids. The following hapens for each: * Test: a Test selector is added and shown to the user. * Group: all Tests from a Group are added to the selector. * Release: a Grid View is shown to the user to pick a single group or test * Test Run: a Test selector is added with a selected run automatically opened
k0machi
force-pushed
the
global-test-searchbar
branch
from
November 4, 2024 09:21
d3de816
to
13fc1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a global search bar to the Workspace page. This bar
allows user to search Argus for any test, group or release names, as
well as specific run ids. The following hapens for each:
test
opened