fix(summary-widget): use upgraded or upgrade-target as summary version #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of scylla being upgraded SUT timestamp was calculated improperly due ignoring upgraded package info.
In case upgrade test fails before upgrading any node, scylla-server-upgrade-target should be taken as Scylla version. Otherwise summary widget won't show such run for given Scylla version.
k0machi
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case upgrade test fails before upgrading any node,
scylla-server-upgrade-target should be taken as Scylla version.
Otherwise summary widget won't show such run for given Scylla version.
Fixed automatic sut_timestamp in results as was not using upgraded version too