Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(highlights): support mentions in highlights widget #568

Merged

Conversation

soyacz
Copy link
Collaborator

@soyacz soyacz commented Jan 3, 2025

Highlights (with action items) now support mentions in content.

closes: #507

@soyacz soyacz requested a review from k0machi January 3, 2025 17:22
@soyacz soyacz force-pushed the highlights-comment-mentions-notifications branch from c27f4c4 to 1d936fc Compare January 7, 2025 13:48
@soyacz soyacz marked this pull request as draft January 8, 2025 11:18
Highlights (with action items) now support mentions in content.

closes: scylladb#507
@soyacz soyacz force-pushed the highlights-comment-mentions-notifications branch from 1d936fc to 8e50a76 Compare January 8, 2025 11:22
@soyacz soyacz marked this pull request as ready for review January 8, 2025 11:22
Copy link
Collaborator

@k0machi k0machi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should also update the normal mention template to the similar template you've added for view mention.

@soyacz soyacz merged commit 4025f65 into scylladb:master Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Notifications when mentioning user in Highlights widget
2 participants