Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): adding bash to support SCT for Scylla enterprice #9

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

CodeLieutenant
Copy link
Collaborator

No description provided.

Signed-off-by: Dusan Malusev <dusan.malusev@scylladb.com>
@CodeLieutenant CodeLieutenant merged commit 3a792b4 into scylladb:master Aug 11, 2024
2 checks passed
@CodeLieutenant CodeLieutenant deleted the bash-in-docker branch August 11, 2024 16:31
@fruch
Copy link

fruch commented Aug 11, 2024

@CodeLieutenant

I think tagging this would to get it into SCT and confirm it's fixing the issue.

@CodeLieutenant
Copy link
Collaborator Author

@CodeLieutenant

I think tagging this would to get it into SCT and confirm it's fixing the issue.

It will not do it automatically as c-s image is bound to 3.12.1 and tagging it to 3.12.2 will not pull, I'm not sure if it's a good idea to point SCT image to :latest as sometimes, c-s, can be broken.

Retagging it to 3.12.1 would require deleting the tag from docker hub (for which I don't think to have permissions)

@fruch would it be better to change SCT to v3.12.2, or go thru like described?

@fruch
Copy link

fruch commented Aug 11, 2024

@CodeLieutenant
I think tagging this would to get it into SCT and confirm it's fixing the issue.

It will not do it automatically as c-s image is bound to 3.12.1 and tagging it to 3.12.2 will not pull, I'm not sure if it's a good idea to point SCT image to :latest as sometimes, c-s, can be broken.

Retagging it to 3.12.1 would require deleting the tag from docker hub (for which I don't think to have permissions)

@fruch would it be better to change SCT to v3.12.2, or go thru like described?

yes, but it wasn't yet created

https://hub.docker.com/r/scylladb/cassandra-stress/tags doesn't show any new versions

@CodeLieutenant
Copy link
Collaborator Author

CodeLieutenant commented Aug 11, 2024

yes, but it wasn't yet created

Sorry, I pushed to my fork and not to this one... Should be up in a couple of minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants