Fix cowHostList can't have hosts with same ConnectAddress
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
fc7d78f
to
6c719e4
Compare
cowHostList uses HostInfo.Equal to confirm host uniqueness, which relies on `ConnectAddress.Equal`, which does not allow to have different hosts with same `ConnectAddress`
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
6c719e4
to
cc58718
Compare
|
Should go to https://github.com/gocql/gocql |
Could go - but if that repo is not responsive ( https://github.com/gocql/gocql/graphs/commit-activity ), we should fix it here. |
|
@dkropachev please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cowHostListusesHostInfo.Equalto confirm host uniqueness, which relies onConnectAddress.Equal, which does not allow to have different hosts with sameConnectAddress.Which leads to apache#1757.
Closes apache#1757