fix(scylla-bench large-partitions): Downgrade scylla-bench to a stable version #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarongilor
force-pushed
the
downgrade_scylla_bench_version
branch
2 times, most recently
from
8419d40
to
5306cb6
Compare
yarongilor
requested review from
fgelcer
and removed request for
bentsi and
psarna
fgelcer
previously approved these changes
Feb 17, 2022
There was a problem hiding this comment.
until s-b issues will be fixed, and it will become stable again, this downgrade is to the last known "good" version:
one of the issues is this one:
scylladb/scylla-bench#91
roydahan
reviewed
Feb 21, 2022
roydahan
reviewed
Feb 21, 2022
| @@ -45,3 +45,6 @@ space_node_threshold: 644245094 | |||
| run_fullscan: '{"ks_cf": "scylla_bench.test", "interval": 10}' # 'ks.cf|random, interval(min)' | |||
|
|
|||
| run_full_partition_scan: '{"ks_cf": "scylla_bench.test", "interval": 2, "pk_name":"pk", "rows_count": 5000, "validate_data": "false"}' # 'ks.cf, interval(sec), partition-key name, number-of-rows-per-partition, validate reversed query output' | |||
|
|
|||
| # Temporarily downgrade scylla_bench to a stable version | |||
| scylla_bench_version: v0.1.3 | |||
There was a problem hiding this comment.
I don't think it happened here as well.
There was a problem hiding this comment.
right, only in this large-partitions longevity, no s-b issues found. can keep the latest version for it.
…e version scylla-bench latest version of 0.1.8 is not stable. Therefore downgrading it on large-partitions relevant longevities.
yarongilor
force-pushed
the
downgrade_scylla_bench_version
branch
from
5306cb6
to
753f587
Compare
roydahan
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/8U4dGEEI
PR pre-checks (self review)
backportlabelssdcm/sct_config.py)unit-test/folder)