-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Full-Partition-Scan): Increase scan interval #5033
Conversation
In order to decrease connection requests load on cluster by scan thread. Intervals of 4 large-partitions longevities are increased to 5 minutes. Fixes: scylladb#4960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No need to backport for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue #4960 it was asked not only to increase the timeout, but to align the unit used (from seconds, to minutes) to be according to run_fullscan
threads..
please change the unit to be in minutes.
I disagree with that. |
the issue this PR claims to fix, has a very clear request: so if we really want to keep it in seconds to still have the ability to return to this smaller granularity, we shall change the other one to use seconds, instead of minutes.. |
Not needed. |
@roydahan , IIUC we are seeing this issue on 2022.1 Azure longevity, as the instances in there are kind of 1/2 of the ones we usually use for the parallel longevity in AWS, so i believe the cluster is super overloaded, and these full scans are surely not helping. or maybe we should disable the full scans for Azure, until we get better quota to run the test with the resources we need? |
I wouldn't disable it, we don't hit too many issues related to high load on 2022.1 branch (perf. is different on master - higher ops/s and load, while on 2022.1 ops/s and load is lower) |
Notes:
That is since it is an important feature to an important customer (Discord) and scylla-bench doesn't have a stable supporting version for that.
https://trello.com/c/U3bhzNUL
PR pre-checks (self review)
backport
labelssdcm/sct_config.py
)unit-test/
folder)