-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): pin scylla-bench to fix multidc counter test #5567
Conversation
We face the issue with disconnecting from cluster after simple table modifications in scylla-bench (counters multidc test): scylladb/scylla-bench#114 It was proven it behaves correctly when s-b is in version 0.1.3. This commit pins s-b for couters multidc test.
@soyacz in the old version you compare with we do use retries. In new one we have concrete limit. So, consider please usage of more retries or bigger intervals for this job. |
@soyacz do have a job run with this pinned ? (running with master ?) |
this is the job with pinned: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/lukasz/job/reproducer-counters-multidc-raft/2/ |
I can try with retries instead of pinning |
I tried and with setting |
ping @fruch |
We need to fix that in s-b, but this PR should be merged meanwhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We face the issue with disconnecting from cluster after simple table modifications in scylla-bench (counters multidc test): scylladb/scylla-bench#114
It was proven it behaves correctly when s-b is in version 0.1.3. This commit pins s-b for couters multidc test.
PR pre-checks (self review)
backport
labelssdcm/sct_config.py
)unit-test/
folder)