Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): pin scylla-bench to fix multidc counter test #5567

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

soyacz
Copy link
Contributor

@soyacz soyacz commented Dec 15, 2022

We face the issue with disconnecting from cluster after simple table modifications in scylla-bench (counters multidc test): scylladb/scylla-bench#114

It was proven it behaves correctly when s-b is in version 0.1.3. This commit pins s-b for couters multidc test.

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

We face the issue with disconnecting from cluster after simple table
modifications in scylla-bench (counters multidc test):
scylladb/scylla-bench#114

It was proven it behaves correctly when s-b is in version 0.1.3.
This commit pins s-b for couters multidc test.
@vponomaryov
Copy link
Contributor

@soyacz in the old version you compare with we do use retries. In new one we have concrete limit. So, consider please usage of more retries or bigger intervals for this job.

@fruch
Copy link
Contributor

fruch commented Dec 15, 2022

@soyacz do have a job run with this pinned ? (running with master ?)

@soyacz
Copy link
Contributor Author

soyacz commented Dec 15, 2022

@soyacz
Copy link
Contributor Author

soyacz commented Dec 15, 2022

@soyacz in the old version you compare with we do use retries. In new one we have concrete limit. So, consider please usage of more retries or bigger intervals for this job.

I can try with retries instead of pinning

@soyacz
Copy link
Contributor Author

soyacz commented Dec 15, 2022

I tried and with setting -timeout 15s -retry-interval=80ms,5s -retry-number=20 failed again after table modification.

@soyacz soyacz requested review from fruch and roydahan January 19, 2023 12:45
@soyacz
Copy link
Contributor Author

soyacz commented Jan 19, 2023

ping @fruch

@roydahan
Copy link
Contributor

We need to fix that in s-b, but this PR should be merged meanwhile.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 8170f3f into scylladb:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants