-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(longevity-counters-multidc): unping scylla-bench #6291
fix(longevity-counters-multidc): unping scylla-bench #6291
Conversation
the case was pinned to older s-b cause of: scylladb/scylla-bench#114 but since then we implemented s-b retires that should fix most of the of the timeout observed in 2023.1 run. Ref: scylladb/scylla-bench#114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is better to update the stress commands to have explicit configuration of the retries and intervals?
We'll run it at least once, and see if we need more than the defaults. Setting them blindly doesn't really goona help |
it works with defaults |
Let's merge and backport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the case was pinned to older s-b cause of: scylladb/scylla-bench#114 but since then we implemented s-b retires that should fix most of the of the timeout observed in 2023.1 run.
Ref: scylladb/scylla-bench#114
PR pre-checks (self review)
backport
labelssdcm/sct_config.py
)unit-test/
folder)