Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(longevity-counters-multidc): unping scylla-bench #6291

Merged

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Jun 25, 2023

the case was pinned to older s-b cause of: scylladb/scylla-bench#114 but since then we implemented s-b retires that should fix most of the of the timeout observed in 2023.1 run.

Ref: scylladb/scylla-bench#114

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

the case was pinned to older s-b cause of: scylladb/scylla-bench#114
but since then we implemented s-b retires that should fix
most of the of the timeout observed in 2023.1 run.

Ref: scylladb/scylla-bench#114
@fruch fruch added backport/5.2 Need backport to 5.2 backport/2023.1 Need to backport to 2023.1 labels Jun 25, 2023
@fruch fruch requested review from vponomaryov and soyacz June 25, 2023 14:59
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to update the stress commands to have explicit configuration of the retries and intervals?

@fruch
Copy link
Contributor Author

fruch commented Jun 26, 2023

Maybe it is better to update the stress commands to have explicit configuration of the retries and intervals?

We'll run it at least once, and see if we need more than the defaults.

Setting them blindly doesn't really goona help

@soyacz
Copy link
Contributor

soyacz commented Jun 27, 2023

Maybe it is better to update the stress commands to have explicit configuration of the retries and intervals?

We'll run it at least once, and see if we need more than the defaults.

it works with defaults

@fruch
Copy link
Contributor Author

fruch commented Jun 27, 2023

Maybe it is better to update the stress commands to have explicit configuration of the retries and intervals?

We'll run it at least once, and see if we need more than the defaults.

it works with defaults

Let's merge and backport

@soyacz soyacz requested a review from vponomaryov June 27, 2023 07:03
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vponomaryov vponomaryov merged commit b1b3fe0 into scylladb:master Jun 27, 2023
@vponomaryov vponomaryov added backport/5.2-done Commit backported to 5.2 backport/2023.1-done Commit backported to 2023.1 labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.2-done Commit backported to 5.2 backport/5.2 Need backport to 5.2 backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants