Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update scylla manager deps to take them from master branch #4056

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

karol-kokoszka
Copy link
Collaborator

@karol-kokoszka karol-kokoszka commented Oct 2, 2024

When managerclient was being extracted to separate submodule, it required on scylla-manager to go get the extracted submodules.
During the development, go get was done with commits from non-master branch.
It can break the builds of siren.

This PR, go gets the dependencies from master.


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@karol-kokoszka karol-kokoszka merged commit 385fb1b into master Oct 2, 2024
49 of 51 checks passed
@karol-kokoszka karol-kokoszka deleted the fix_dependencies branch October 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant