Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore improvement: batch retry #4071

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Restore improvement: batch retry #4071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
53a05e9
feat(restore): make batches retryable
Michal-Leszczynski Oct 15, 2024
1e0a40d
feat(restore_test): test batch retry
Michal-Leszczynski Oct 15, 2024
3a38f28
refactor(restore): flatten workload structure
Michal-Leszczynski Oct 16, 2024
88f0547
feat(restore): add host retries
Michal-Leszczynski Oct 16, 2024
f3baac6
feat(restore): extend batch test with host retry
Michal-Leszczynski Oct 16, 2024
62c8c1d
refactor(restore): make batchDispatcher more comprehensible
Michal-Leszczynski Oct 18, 2024
473000f
fix(restore): free host when it can't restore anymore
Michal-Leszczynski Oct 21, 2024
2eb9e4a
feat(restore): improve context cancelling during batching
Michal-Leszczynski Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/service/backup/backupspec/location.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,19 @@ func NewLocation(location string) (l Location, err error) {
}

func (l Location) String() string {
p := l.Provider.String() + ":" + l.Path
p := l.StringWithoutDC()
if l.DC != "" {
p = l.DC + ":" + p
}
return p
}

// StringWithoutDC returns Location string representation
// that lacks DC information.
func (l Location) StringWithoutDC() string {
return l.Provider.String() + ":" + l.Path
}

// Datacenter returns location's datacenter.
func (l Location) Datacenter() string {
return l.DC
Expand Down
Loading
Loading