Swagger: backup and restore Scylla API #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can be used to abort Scylla task, check its progress, etc... Definitions were taken from: https://github.com/scylladb/scylladb/blob/f3f956841fc4fb720626de2d036478d64c76dd3a/api/api-doc/task_manager.json#L5
They will eventually be used to replace currently used rclone server. Definitions were taken from: https://github.com/scylladb/scylladb/blob/ee92784098689125708f88fa9441ccd8e68b6ae9/api/api-doc/storage_service.json#L758
|
@karol-kokoszka This PR is ready for review! The failure is a know flake (#3848). |
|
@karol-kokoszka This PR is ready for review! |
|
@Michal-Leszczynski is the scylla_v1.json taken from scylla repo ? Or the new endpoints at least ? |
|
Yes - all swagger definitions from scylla_v1 are taken from Scylla repo (from many files), but they have to be adjusted to the swagger 2.0 format. I can add comments with per-file link to our swagger definitions. |
Please do. |
|
@karol-kokoszka I decided to add a separate |
VAveryanov8
approved these changes
Nov 12, 2024
karol-kokoszka
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds swagger definitions for Storage Service Backup and Restore Scylla API that will be used to replace currently used rclone endpoints.
This PR also includes swagger definitions for Task Manager Scylla API that can be used for managing running Backup and Restore Scylla jobs.