-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(restore): adds exclusive cluster lock for restore task #4122
Conversation
This makes the scheduler run the restore task only if no other tasks (backup or repair) are running in the cluster. Conversely, other tasks (backup or repair) won't start if the restore task is running in the cluster at that time. Refs: #4045.
This is how output of a
and this is how output of a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice tests!
Just left a small refactor oriented comments.
The strange thing is that we report it as an error, but that's not connected to this PR at all. |
Why not |
This moves part of the logic to separate method to improve readability and fixes how PostRun cleans up the resources.
@Michal-Leszczynski I've updated the pr, I'd appreciate if you could take a look one more time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
This makes the scheduler run the restore task only if no other tasks (backup or repair) are running in the cluster. Conversely, other tasks (backup or repair) won't start if the restore task is running in the cluster at that time.
Fixes: #4045.
Please make sure that: