build: allow CMake to find Boost using package config #2537
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "MODULE" parameter from `find_package(Boost)` call to allow using Boost's provided BoostConfig.cmake instead of CMake's FindBoost module. This aligns with CMake 3.30's policy CMP0167 which deprecates FindBoost.cmake. Background: - We previously dropped our vendored FindBoost.cmake in bf684ac - CMake is deprecating its FindBoost module as Boost now provides its own package config files - Using Boost's config files is the recommended approach going forward This change: - Silences [CMP0167](https://cmake.org/cmake/help/latest/policy/CMP0167.html) policy warnings like ``` CMake Warning (dev) at CMakeLists.txt:133 (find_package): Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake --help-policy CMP0167" for policy details. Use the cmake_policy command to set the policy and suppress this warning. ``` - Removes outdated comments about bundled FindBoost.cmake, which was removed in bf684ac. - Enables using Boost's native package configuration Refs bf684ac Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
2 similar comments
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "MODULE" parameter from
find_package(Boost)call to allow using Boost's provided BoostConfig.cmake instead of CMake's FindBoost module. This aligns with CMake 3.30's policy CMP0167 which deprecates FindBoost.cmake.Background:
This change:
CMake Warning (dev) at CMakeLists.txt:133 (find_package): Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake --help-policy CMP0167" for policy details. Use the cmake_policy command to set the policy and suppress this warning.Refs bf684ac