Add resampling info message #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display in the plugin when resampling is happening.
Running with my interface set to 44.1kHz.
I was on the fence about this--most plugins don't say when they're doing resampling internally. But, I think it's important to call out here because (1) it adds several ms of latency and (2) it's something that the user can affect in unexpected ways--unlike other non-open-source modelers out there, NAM lets you train models at whatever sample rate you want. So this could be very unexpected to a user (e.g. if they stumble upon a model trained at 96k by some power user).
Additionally, if someone stacks NAMs (e.g. OD into an amp) then the total added latency from two instances (over 5 ms due to resampling alone) may become noticeable and negatively impact the playing experience.
I don't want this to be mysterious. I want folks to be informed about it so that they can (if they desire) pick a sample rate that works with the model they're using that enables the plugin to avoid the need to resample and therefore not add latency.