Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Output calibration #531

Merged
merged 4 commits into from
Nov 23, 2024
Merged

[FEATURE] Output calibration #531

merged 4 commits into from
Nov 23, 2024

Conversation

sdatkinson
Copy link
Owner

@sdatkinson sdatkinson commented Nov 22, 2024

Description

Implement output calibration. Resolves #529

Normalized output is selected:
image

Example when the model doesn't support output calibration:
image

And when normalized output isn't supported:
image

If a non-supported option is chosen, then raw output will be used.

The "Normalize" control is removed from the front page since this extends it:
image
and the default will still be "normalized output" for consistency. Calibrated output is probably most useful for pedal models.

Might want to put some control on the "front page" when the selected output mode isn't supported? Maybe an orange Exclamation point in a circle and make the gear orange? Not sure.

PR Checklist

Raw/Normalized/Calibrated
Control layout and style needs work
Need to work on "disabling" based on what's available from the model's metadata.
@sdatkinson sdatkinson merged commit e7dd8b5 into main Nov 23, 2024
2 checks passed
@sdatkinson sdatkinson deleted the 529-output branch November 23, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] output calibration
1 participant