improve(logs): allow logs without a message

sdnts · Sep 16, 2023 · c58d594 · c58d594
1 parent 28c139e
commit c58d594
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 3 deletions.
diff --git a/src/endpoints/logs.ts b/src/endpoints/logs.ts
@@ -19,7 +19,7 @@ export const LogSchema = z.object({
   }),
 
   // Text content of the log
-  message: z.string(),
+  message: z.string().optional(),
 
   // Metadata specific to this log line
   kv: LogKVSchema.optional(),

diff --git a/tests/logs.test.ts b/tests/logs.test.ts
@@ -285,7 +285,7 @@ test("with both kv", async () => {
   });
 });
 
-test('with undefined kv values', async () => {
+test("with undefined kv values", async () => {
   const res = await logs
     .ship(
       {
@@ -320,7 +320,42 @@ test('with undefined kv values', async () => {
       },
     ],
   });
-})
+});
+
+test("with no message", async () => {
+  const res = await logs
+    .ship(
+      {
+        success: true,
+        data: {
+          service: "blob-city",
+          environment: "production",
+          kv: { common: undefined },
+          logs: [
+            {
+              level: "info",
+              timestamp: { p: "ns", v: "001" },
+            },
+          ],
+        },
+      },
+      env,
+    )
+    .then((r) => r.json());
+
+  expect(res).toStrictEqual({
+    streams: [
+      {
+        stream: {
+          environment: "production",
+          service: "blob-city",
+          level: "info",
+        },
+        values: [["001", ""]],
+      },
+    ],
+  });
+});
 
 test("multiple logs", async () => {
   const res = await logs