Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light: use placeholder foreground for ansi white #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkhl
Copy link

@mkhl mkhl commented Mar 25, 2022

in the light theme, the ansi whites are illegible on the default terminal background
(yes sadly some commands do stuff like that)

this change reuses the placeholder foreground color for the whites to fix that

@mkhl
Copy link
Author

mkhl commented Mar 25, 2022

output of esbuild --help
before:
terminal white before

and after:
terminal white after

@mkhl
Copy link
Author

mkhl commented Mar 25, 2022

hmm actually i think #CCCCCC has better contrast against other colors 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant